Allow custom mysql flags for db exec command #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadamwhite
reviewed
Nov 29, 2022
inc/composer/class-command.php
Outdated
| $options = $input->getArgument( 'options' ) ?? []; | ||
| array_shift( $options ); // remove the subcommand, we don't need it | ||
| $query = array_pop( $options ) ?: null; // the query is always the last option | ||
| $args = count( $options ) > 1 ? implode( ' ', $options ) : ''; // implode all optional options |
There was a problem hiding this comment.
Elsewhere in this file the comments are all on their own line before the code they're describing, rather than line-ending comments. I'd suggest maintaining "keep comments on their own line" for consistency with the existing style.
shadyvb
commented
Nov 29, 2022
roborourke
reviewed
Dec 20, 2022
Co-authored-by: Robert O'Rourke <robert@o-rourke.org>
roborourke
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #548