Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe SVG is remote fetching images from S3 #277

Closed
joehoyle opened this issue Nov 11, 2022 · 1 comment · Fixed by #278
Closed

Safe SVG is remote fetching images from S3 #277

joehoyle opened this issue Nov 11, 2022 · 1 comment · Fixed by #278
Labels
bug Existing functionality isn't behaving as expected

Comments

@joehoyle
Copy link
Member

The Safe SVG plugin is remote fetching data in https://github.com/10up/safe-svg/blob/develop/safe-svg.php#L290. This is called via wp_get_attachment_image_src() which happens a lot of the time. On many page loads that then include SVGs this will slow down the page load a lot.

This is to set the image dimensions from things like viewBox or width / height attributes. I think we need to remove that behavior, but there's no simple way to unhook this, as it's part of a self initialized class with no global handle.

@joehoyle joehoyle added the bug Existing functionality isn't behaving as expected label Nov 11, 2022
@joehoyle
Copy link
Member Author

Looks like this might be also tracks in 10up/safe-svg#75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Existing functionality isn't behaving as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant