Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump eslint-plugin-react to > 7.14.0 #194

Closed
mikeselander opened this issue Apr 21, 2020 · 1 comment · Fixed by #197
Closed

Bump eslint-plugin-react to > 7.14.0 #194

mikeselander opened this issue Apr 21, 2020 · 1 comment · Fixed by #197
Projects
Coding Standards Triage 2020-05-19

Comments

@mikeselander
Copy link
Contributor

We added the jsx-curly-newline rule in 0.8.0, but our linter only pulls in 7.11 of eslint-plugin-react. However, that rule was added in 7.14. We need to bump this version and we likely need to release an 0.8.1 version because the linter bot will throw a load of errors.
@kadamwhite
Copy link
Contributor

Needs to go out prior to the 1.0 bump

@mikeselander mikeselander mentioned this issue May 20, 2020
Merged
@mikeselander mikeselander moved this from To do to Needs Review in Coding Standards Triage 2020-05-19 May 20, 2020
@mikeselander mikeselander moved this from Needs Review to Done in Coding Standards Triage 2020-05-19 May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Coding Standards Triage 2020-05-19
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ESLInt Rules of Hooks ruleset humanmade/coding-standards
2 participants
@kadamwhite @mikeselander