Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PHPCS to 3.3 #70

Closed
mikeselander opened this issue Jul 17, 2018 · 0 comments · Fixed by #88
Closed

Update PHPCS to 3.3 #70

mikeselander opened this issue Jul 17, 2018 · 0 comments · Fixed by #88
Assignees
@mikeselander

Comments

@mikeselander
Copy link
Contributor

mikeselander commented Jul 17, 2018 •
edited
Loading

PHPCS 3.3 fixes an issue whereby the end of comment blocks was mis-identifed if a phpcs:disable/enable rule was included in the block. This is causing false issues in a client repo (ask me for more details if necessary). We should upgrade if there are not other various issues that arise form the upgrade.

See squizlabs/PHP_CodeSniffer#1918 for more details on the specific issue that I'me seeing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikeselander mikeselander

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update PHPCS to v3.4 humanmade/coding-standards
1 participant
@mikeselander