Skip to content
This repository has been archived by the owner on Jun 25, 2023. It is now read-only.

Support nullsafety #37

Closed
onethao opened this issue Mar 20, 2021 · 8 comments
Closed

Support nullsafety #37

onethao opened this issue Mar 20, 2021 · 8 comments

Comments

@onethao
Copy link

onethao commented Mar 20, 2021

Hi,

Can you update pack support nullsafety?

Because optimized_cached_image >=2.0.0-dev.1 depends on octo_image ^0.3.0 and cached_network_image 3.0.0-nullsafety depends on octo_image ^1.0.0-nullsafety, optimized_cached_image >=2.0.0-dev.1 is incompatible with cached_network_image 3.0.0-nullsafety.
And because no versions of cached_network_image match >3.0.0-nullsafety <4.0.0, optimized_cached_image >=2.0.0-dev.1 is incompatible with cached_network_image ^3.0.0-nullsafety.
So, because onedanang depends on both cached_network_image ^3.0.0-nullsafety and optimized_cached_image ^2.0.0-dev.2, version solving failed.
pub get failed (1; So, because onedanang depends on both cached_network_image ^3.0.0-nullsafety and optimized_cached_image ^2.0.0-dev.2, version solving failed.)

Thanks

@humblerookie
Copy link
Owner

I'm sorry those are pre-release versions, and it would be premature to provide support for it. You may use dependency_overrides if you wish to work with those.

@onethao
Copy link
Author

onethao commented Mar 21, 2021

yes, in understand but now need nullsafety with new version. Can you update?

@britannio
Copy link
Contributor

@humblerookie It seems like all the dependencies of this package have migrated to null safety and thus this package is ready to be migrated. Will you be doing this?

@humblerookie
Copy link
Owner

@britannio I'm going to be busy this week, if you're comfortable contributing that would be great too.

@onethao
Copy link
Author

onethao commented Mar 28, 2021

@humblerookie These packages depend are fastest version support null safety. Can you update?
octo_image: ^1.0.0
flutter_cache_manager: ^3.0.0
flutter_image_compress: ^1.0.0

@britannio
Copy link
Contributor

@humblerookie These packages depend are fastest version support null safety. Can you update?
octo_image: ^1.0.0
flutter_cache_manager: ^3.0.0
flutter_image_compress: ^1.0.0

Do you just need the dependencies to be updated now or do you also require this package to itself be null safe?

@onethao
Copy link
Author

onethao commented Mar 29, 2021

yes, update dependencies will support null safe.

@onethao
Copy link
Author

onethao commented Apr 2, 2021

It's working with optimized_cached_image: ^2.0.1. Thanks

@onethao onethao closed this as completed Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants