Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if(!F[T]): Isn't this test too simple? #11

Closed
cheako opened this issue May 12, 2018 · 1 comment
Closed

if(!F[T]): Isn't this test too simple? #11

cheako opened this issue May 12, 2018 · 1 comment
Labels
Valuable Suggestion (Sunsetted) Issue acknowledged. Open in meantime for community discussion and potential future exploration.

Comments

@cheako
Copy link

cheako commented May 12, 2018

glm-js/src/glm.common.js

Line 557 in aef4fd1

if (!F[T])

Shouldn't this be something like if(T in F)?
@humbletim humbletim added the Valuable Suggestion (Sunsetted) Issue acknowledged. Open in meantime for community discussion and potential future exploration. label Feb 12, 2024
@humbletim
Copy link
Owner

Thank you for the suggestion regarding if (T in F) (2018). While the project is now sunsetting (see #19), I appreciate you bringing it up! Best regards, -Tim

@humbletim humbletim closed this as not planned Won't fix, can't repro, duplicate, stale Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Valuable Suggestion (Sunsetted) Issue acknowledged. Open in meantime for community discussion and potential future exploration.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@humbletim @cheako