-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a close-button to the window to minimize Clipdinger #31
Comments
I'm not sure that's a good idea WRT to consistency around the system. Normally the close button in the window tab quits the application, if it's the last or main window. Which is the case with Clipdinger. |
While I understand the intention, IMO, not having a close button on a windows that's not just a "transient dialog" breaks the "principle of least astonishment". A window without close button, needs, IMO, a very good reason to break that expectation. Some dialogs that have, say, an "Apply" button that also closes the window... yeah... those might dispense of the titlebar close button. But it is not the case here, I think. Your own QuickLaunch has a close button, and it doesn't "quits" the app, just "hides" it in Deskbar. (Hoping here you don't decide to remove that one! :-P). In any case, different folks for different strokes, of course. Thanks for considering this suggestion. Thanks again for such useful tool! Comes in handy when dealing with Python recipe cleanups (too bad that sometimes I forget to use it, LOL!). |
Not true. QuickLaunch does actually quit. :) Anyway, I came around to your way of thinking about that close button. However - and that may be the reason I removed it in the first place - I don't know how to override the close button. When pressed, it seems to invoke QuitRequested() directly, which leads to quitting the app. I have now introduced a flag that has to be set to 'true' before actually quitting. Maybe not totally elegant, but until I can teach the window close-button to send a message instead of quitting directly... |
Topic says it all.
The text was updated successfully, but these errors were encountered: