Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter tool doesn't activate the encoded filters #895

Closed
jacekiwaszko1 opened this issue May 14, 2024 · 1 comment
Closed

filter tool doesn't activate the encoded filters #895

jacekiwaszko1 opened this issue May 14, 2024 · 1 comment
Assignees

Comments

@jacekiwaszko1
Copy link
Collaborator

jacekiwaszko1 commented May 14, 2024

The filter tool should activate the filter encoded in the file, but it isn't working now.

**kern	**kern
1c	1cc
=	=
*-	*-
!!!filter-test: extract -s 1
!!!filter: filter -v test

After adding the filter -v test to the code above it should be rendered as single staff due to extract -s 1, but nothing changes:

image

After compiling, the HTML code with the help page is added at the beginning of the file, as if the option -v was not recognized:

!!@@BEGIN: PREHTML
!!<table>
!!   <tr>
!!      <th>Option</th><th>Type</th><th>Default</th><th>Description</th>
!!   </tr>
!!   <tr>
!!     <td>--debug</td><td>boolean </td><td>boolean </td><td> </td><td>print debug statement </td>
!!   </tr>
!!   <tr>
!!     <td>-v</td><td>string </td><td>string </td><td> </td><td>Run filters labeled with the given variant </td>
!!   </tr>
!!</table>
!!@@END: PREHTML
**kern	**kern
1c	1cc
=	=
*-	*-
!!!filter-test: extract -s 1
!!!Xfilter: filter -v test
@craigsapp
Copy link
Member

craigsapp commented May 14, 2024

Fixed:

Screenshot 2024-05-14 at 4 42 23 AM

I was testing how to display options for a filter above the notation (but it was not finished when I got distracted and somehow it activated with the filter filter). I have removed the code for now and things are behaving for me (and should on the POPC2 website and VHV).

@craigsapp craigsapp self-assigned this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants