pdf, txt file access for guests not working

[buddh4]

Invalid permission check for public file guest access:

https://community.humhub.com/content/perma?id=191007

[ferkulum]

Hi @buddh4 - can you reproduce this bug? Our users already complain about it :( What can we do?

[ferkulum]

@buddh4 - Hi, this bug is still open and confuses users a lot. Did you try to reproduce it?

[ferkulum]

@luke- Thanks for taking another look on the bug and labeling it. We had to deactivate OnlyOffice because of it, but our users already miss it. Can you reproduce the bug? I can also add a quick screencast to show it. How are your priorities here?

[ferkulum]

@luke- @buddh4 Hi, just for clarification - is this an issue which cannot be adressed without external help? More and more users from our HumHub instance complain about this.

[buddh4]

@luke- can you recreate this, perhas just skip opening pdfs with only office by default? Or skipping only office for guest users in general.

[SocioHub-FID]

@buddh4 @luke- can you recreate this bug? For our users this is still a fatal bug :(

I guess this could be bad for other HumHub users as well: If the OnlyOffice-Module is activated, logged-out users cannot access public files in spaces.

[luke-]

I think skipping only office for guest users would be a good work around?

To do so, we just need something like if (Yii::$app->user->isGuest) return; here:
https://github.com/humhub-contrib/onlydocuments/blob/master/Events.php#L24

@sociohub-gesis what do you think?

Can you prepare a PR here: http://github.com/onlYOFFICE/onlyoffice-humhub/ ?

[SocioHub-FID]

@luke- @buddh4 - thanks a lot for your answer. We implemented the code you suggested locally to skip only office for guests. Basically it worked, but the problem now is that guests do not see any public files anymore. The spaces are in our case also used a public pages and guests have to see public files. What can we do now from your perspective?

[SocioHub-FID]

@luke- @buddh4 - What can we do now from your perspective? I bug is still there and our users would highly benefit from using the OnlyOffice module at the same time the files must be available for guests.

[cboulanger]

Hi,

I am one of the sociohub users who really need onlyoffice integration, and am happy to help if I can - I have some Yii2 experience.

@buddh4 , do you have a sense of what would be needed to get this working, i.e. letting guests view public files AND prevent them from accessing onlyoffice documents - I assume that's what the original bug is about, which I cannot access (I am getting a empty result even when logged into the community hub).

[luke-]

Please excuse the long delays here!

Can you confirm that this PR solves the problem?
humhub/humhub#4363