Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent context menus after update to version 0.14.2 #155

Closed
psg-webdev opened this issue Apr 4, 2022 · 3 comments
Closed

Inconsistent context menus after update to version 0.14.2 #155

psg-webdev opened this issue Apr 4, 2022 · 3 comments
Assignees

Comments

@psg-webdev
Copy link

We use HumHub Professional Edition 1.10.3 with Enterprise Theme 1.7.2.
After updating from version 0.13.1 to 0.14.2 the following phenomenon occurs in the file - listing (cfiles/browse):

Some entries have very short context menus with the following entries:

  • Download
  • Show entry
  • Show link
  • Edit entry
  • Delete entry
  • Move
  • Version
  • Lock comments section

Screenshot 1:

scr_cfiles_context_short

Others in the exact same list have longer context menus with the following entries:

  • Download
  • Show entry
  • Show Link
  • Edit entry
  • Delete item
  • Move
  • Versions
  • Themes
  • Change to "Public
  • Lock comment section
  • Disable notifications / Enable notifications

Screenshot 2:

scr_cfiles_context_long

This doesn't seem right to me apart from missing translations ("Versions").
Or do I have a comprehension problem here? If so, please clarify.

Thanks in advance

@yurabakhtin
Copy link
Contributor

@psg-webdev We have more menu entries only for files which were uploaded through file manager, because in such case the file is created as separate wall entry and we can see it in space/user stream, so only for such files we can display menu entry like Change to "Public". But if a file was attached to some post content then it is not separate wall entry and we cannot use some options for such files.

@luke- Do you agree?

@psg-webdev
Copy link
Author

@yurabakhtin So this is not an error but a special context:

  • If the file was uploaded without context (post) it has only a few items in the menu.
  • If the file was uploaded in the context of a post (as attachment) then the menu is extended here.

Do I understand this correctly?

Regards

@yurabakhtin
Copy link
Contributor

@psg-webdev Yes, it depends on the uploading way, but you mixed up, because it works like this:

  • If the file was uploaded without context (post) it has the extended menu, because here it is a separate wall entry, so it can be private/public, can be commented, can has topics and etc. i.e. it can has all options as normal post.
  • If the file was uploaded in the context of a post (as attachment) then only a few items in the menu, because it is not a wall entry i.e. it cannot has the options what can be applied to normal post.

@luke- luke- closed this as completed Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants