Public space is not displayed when guest user accesses "Space directory".

[sakurafarm]

What steps will reproduce the problem?

1. Administration -> Users-> Settings -> General -> Enable "Allow limited access for non-authenticated users (guests)"

2. Create a public space (VISIBILITY_ALL) that guests and registered users can access.

3. Access "Space directory" as a guest user. (Directory -> Spaces)

What is the expected result?

Public space is displayed.

What do you get instead?

Public space is not displayed.

Additional info

Q	A
HumHub version	1.4.0-beta.1
PHP version	7.1

[buddh4]

Could not reproduce this issue, you probably have to rebuild the search index. http://docs.humhub.org/admin-search.html#index-rebuilding

[sakurafarm]

The search index was rebuilt, but public space is not visible to guest users.

It is displayed without problems for the logged-in user.

It may be a wrong fix, but if I set the space.visibility of ActiveQuerySpace.php (Line56) to 2, it will be displayed correctly even for guest users.

[buddh4]

Yes there is a public visibility (members only) and a public visibility (members and guests) this can be changed in the space security settigns

[sakurafarm]

@buddh4
It was not displayed even in 1.4.0-beta.2.

[buddh4]

@luke- , I can only imagin a search index issue? Any idea?

[sakurafarm]

@buddh4
I noticed that public spaces(members and guests) where the logged-in user is not a member are not displayed in the space directory.

I think the cause is the humhub\modules\space\components\ActiveQuerySpace visible ().

[buddh4]

@luke- there is space visibility_all missing in the visibility query?

humhub/protected/humhub/modules/space/components/ActiveQuerySpace.php

Lines 45 to 59 in d73ffac

	if ($user !== null) {
	$spaceIds = array_map(function (Membership $membership) {
	return $membership->space_id;
	}, Membership::findAll(['user_id' => $user->id]));
	$this->andWhere(['OR',
	['space.visibility' => 1],
	['IN', 'space.id', $spaceIds]
	]);
	} else {
	$this->andWhere(['space.visibility' => 1]);
	}
	return $this;
	}

Also if user is null space.visibility needs to be 2 ?

[sakurafarm]

@luke- 0ffed46 is not compatible with Humhub1.3 for displaying results.

In Humhub 1.3, the space VISIBILITY_REGISTERED_ONLY and VISIBILITY_ALL will be displayed to guest users. I think this specification is desirable.

Is it possible to include both VISIBILITY_REGISTERED_ONLY and VISIBILITY_ALL in the search condition when a guest user?

[ArchBlood]

I believe you'd have to use something like this

Not tested

            }, Membership::findAll(['user_id' => $user->id]));
            $this->andWhere(['OR',
                ['space.visibility' => 1],
                ['!=', 'space.visibility', Space::VISIBILITY_REGISTERED_ONLY && Space::VISIBILITY_ALL],
                ['IN', 'space.id', $spaceIds]
            ]);
        } else {
            $this->andWhere(['space.visibility' => 1]);
            $this->andWhere(['space.visibility' => Space::VISIBILITY_REGISTERED_ONLY && Space::VISIBILITY_ALL]);
        }
        return $this;
    }

[buddh4]

Should this be configurable, I'am not sure if its obvious that VISIBILITY_REGISTERED_ONLY spaces are visible for guests in the directory. But I see that this can be desirable in some cases.

At least there should be a help text that this space will show up for guests in the directory.

[buddh4]

@luke- what do you think?