Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal scrollbar for images #4959

Closed
marc-farre opened this issue Mar 12, 2021 · 4 comments
Closed

Horizontal scrollbar for images #4959

marc-farre opened this issue Mar 12, 2021 · 4 comments
Assignees
Labels

Comments

@marc-farre
Copy link
Collaborator

Upload a wide picture in a post, wikipage or other Richtext:
image

The image has width="100%" wich is correct, but also margin: 0 5px; which creates an horizontal scrollbar:
https://github.com/humhub/humhub/blob/master/static/less/markdown.less#L168

[data-ui-richtext] img:not(.center-block) {
    max-width: 100%;
    margin: 0 5px;
}
Q A
HumHub version 1.8
@yurabakhtin
Copy link
Contributor

@luke- PR #4961

@luke-
Copy link
Contributor

luke- commented Mar 12, 2021

@yurabakhtin Does it still look good now without margin or Is there no difference? Can you please post a screenshot?
Maybe you should use a padding instead of a margin?

@yurabakhtin
Copy link
Contributor

@luke- It looks like without margin, if we need the space then yes we should use a padding, should I use padding?

tests

@luke-
Copy link
Contributor

luke- commented Mar 12, 2021

@yurabakhtin Thanks for the screenshots. The variant without margin is really the best. I'll merge the PR.

@luke- luke- closed this as completed Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants