Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity Mail Broken due QueryParams #4985

Closed
luke- opened this issue Mar 30, 2021 · 1 comment
Closed

Activity Mail Broken due QueryParams #4985

luke- opened this issue Mar 30, 2021 · 1 comment

Comments

@luke-
Copy link
Contributor

luke- commented Mar 30, 2021

What steps will reproduce the problem?

Could not send activity mail to: XXX (Calling unknown method: yii\console\Request::getQueryParam()#0 /srv/humhub/protected/humhub/modules/stream/actions/Stream.php(192): yii\base\Component->__call('getQueryParam', Array) #1 /srv/humhub/protected/vendor/yiisoft/yii2/base/BaseObject.php(109): humhub\modules\stream\actions\Stream->init() #2 /srv/humhub/protected/vendor/yiisoft/yii2/base/Action.php(62): yii\base\BaseObject->__construct(Array) #3 /srv/humhub/protected/humhub/modules/activity/components/MailSummary.php(147): yii\base\Action->__construct('stream', Object(yii\queue\db\Command), Array) #4 /srv/humhub/protected/humhub/modules/activity/components/MailSummary.php(79): humhub\modules\activity\components\MailSummary->getActivities() #5 /srv/humhub/protected/humhub/modules/activity/components/MailSummaryProcessor.php(67): humhub\modules\activity\components\MailSummary->send() #6 /srv/humhub/protected/humhub/modules/activity/jobs/SendMailSummary.php(59): humhub\modules\activity\components\MailSummaryProcessor::process(1) #7 /srv/humhub/protected/humhub/modules/queue/ActiveJob.php(33): humhub\modules\activity\jobs\SendMailSummary->run() #8 /srv/humhub/protected/vendor/yiisoft/yii2-queue/src/Queue.php(246): humhub\modules\queue\ActiveJob->execute(Object(humhub\modules\queue\driver\MySQL)) #9 /srv/humhub/protected/vendor/yiisoft/yii2-queue/src/cli/Queue.php(162): yii\queue\Queue->handleMessage('137446', 'O:44:"humhub\mo...', '3600', '1') #10 /srv/humhub/protected/vendor/yiisoft/yii2-queue/src/cli/Command.php(146): yii\queue\cli\Queue->execute('137446', 'O:44:"humhub\mo...', '3600', '1', '14616') #11 [internal function]: yii\queue\cli\Command->actionExec('137446', '3600', '1', '14616') #12 /srv/humhub/protected/vendor/yiisoft/yii2/base/InlineAction.php(57): call_user_func_array(Array, Array) #13 /srv/humhub/protected/vendor/yiisoft/yii2/base/Controller.php(181): yii\base\InlineAction->runWithParams(Array) #14 /srv/humhub/protected/vendor/yiisoft/yii2/console/Controller.php(184): yii\base\Controller->runAction('exec', Array) #15 /srv/humhub/protected/vendor/yiisoft/yii2/base/Module.php(534): yii\console\Controller->runAction('exec', Array) #16 /srv/humhub/protected/vendor/yiisoft/yii2/console/Application.php(181): yii\base\Module->runAction('queue/exec', Array) #17 /srv/humhub/protected/vendor/yiisoft/yii2/console/Application.php(148): yii\console\Application->runAction('queue/exec', Array) #18 /srv/humhub/protected/vendor/yiisoft/yii2/base/Application.php(392): yii\console\Application->handleRequest(Object(yii\console\Request)) #19 /srv/www/htdocs/community/yii.php(38): yii\base\Application->run() #20 {main})

Related Commit: 3e7d39c#diff-5c61435181cd93284ced192dc250e7ff5d285ec5c5f9e5495e68e6444b9c4fae

We need to check for Console Action before accessing query params

@yurabakhtin
Copy link
Contributor

@luke- Thank you for the link where it was broken.
Fixed in PR #4986.
Also the same bug was reported in the issue humhub/tasks#102.

@luke- luke- closed this as completed May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants