Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block button into profil #5751

Closed
antho2305 opened this issue Jun 6, 2022 · 18 comments · Fixed by #6689
Closed

Add block button into profil #5751

antho2305 opened this issue Jun 6, 2022 · 18 comments · Fixed by #6689

Comments

@antho2305
Copy link

Is your feature request related to a problem? Please describe.

It's complicated to block someone have to go to profil setting > setting -> block user

Describe the solution you'd like

It would be great to have a button or icon to block user directly from the profil next to "follow" "ask friend" and the possitibily to report the user (without needing a post)

Describe alternatives you've considered

nothing

@Raphaa2022
Copy link

I agree!

@luke-
Copy link
Contributor

luke- commented Nov 21, 2023

  • Add the cog wheel button also to the profile, same as on Spaces e.g.
    image
  • Add "Block" feature
  • For User admins, add an "Edit" option
  • If "Friendship" + "Follow" is enabled, move "Follow" into the new menu

This menu will probably have further entries in the future, such as a "Report Profile"

@yurabakhtin yurabakhtin linked a pull request Nov 30, 2023 that will close this issue
5 tasks
@yurabakhtin
Copy link
Contributor

@luke- PR #6689:

user-menu

@luke-
Copy link
Contributor

luke- commented Dec 1, 2023

@yurabakhtin Thanks!

@Eladnarlea What do you think of the icons?

@Eladnarlea
Copy link

@luke- maybe an exclamation mark would be more fitting as this action has consequences. What do you reckon?

On top of that the √ following should either be an X unfollow to signalise an action or should be outsourced of the dropdown menu as we don't use a dropdown menu to show states but aquire action.

@luke-
Copy link
Contributor

luke- commented Dec 7, 2023

For Friendship Actions & Unfollow we already have some confirm dialog.
image

We definitly add some for Cancel Membership.
@Semir1212 Can you please provide some text here?

@Eladnarlea Then lets go with your suggestion √ following should either be an X unfollow.

@yurabakhtin Can you please adapt?

@yurabakhtin
Copy link
Contributor

Can you please adapt?

@luke- Sorry, but I don't understand what to do.

Please note I used the icon because it was used in previous button and it is still used on the "People" page:

header-actions
people-card

but the button "Follow" has no icon:

follow-header
follow

@luke-
Copy link
Contributor

luke- commented Dec 7, 2023

@yurabakhtin When there is a confirm dialog on unfollow. Anything is fine for now. Thanks

@Semir1212 Can you please provide texts for "Leave space" confirm dialog?

@Semir1212
Copy link
Contributor

Semir1212 commented Dec 7, 2023

@luke- @yurabakhtin Text ist fine. Same like unfollow:

Would you like to leave Space "Space Name"?

Follow button looks off:

image

@yurabakhtin
Copy link
Contributor

Would you like to leave Space "Space Name"?

@Semir1212 I have found we already use a confirmation but with different text, should I update the old text to your new suggested?

existing-space-leaving-msg

@Semir1212
Copy link
Contributor

@yurabakhtin Just change "Confirm Action" to "Leave Space". Rest is fine.

@yurabakhtin
Copy link
Contributor

@Semir1212 @luke- Done in commit ded523f:

space-leave

spaces

@luke-
Copy link
Contributor

luke- commented Dec 8, 2023

@yurabakhtin Thanks!

@luke- luke- closed this as completed Dec 8, 2023
@Eladnarlea
Copy link

@Semir1212 @luke- We should rename the button text to "Leave" or even better "Leave space". From a UX point of view, it's clearer that way, especially because this is an action that can't simply be undone.

@luke-
Copy link
Contributor

luke- commented Dec 11, 2023

image

Can you please rename the confirm leave space buttton to "Leave".

@yurabakhtin
Copy link
Contributor

@luke- PR #6722:

leave-btn

@luke- luke- closed this as completed Dec 11, 2023
@Eladnarlea
Copy link

Screenshot 2023-12-14 at 12 06 30 PM

@luke- we should also review the logic regarding the √ following and change it to X unfollow to uniform it. Actually this is a mistake in UI/UX Design because it is in the style of a button but it actually functions as a badge. Same for √ friends X unfriend

@Eladnarlea Eladnarlea reopened this Dec 14, 2023
@luke-
Copy link
Contributor

luke- commented Dec 14, 2023

@Eladnarlea Hmm, we should create a separate issue for this. Can you please create?

I actually think it's nice that it says "√ follow" like a badge. I wouldn't like an unfollow button in this overview

@luke- luke- closed this as completed Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants