Update sphinx-tabs to its latest version
#117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
changed the title
sphinx-tabs to its latest version
humitos
force-pushed
the
humitos/update-sphinx-tabs
branch
from
1a9fdb3
to
878ca2e
Compare
If `sphinx_tabs/tabs.js` is not found and `_static/tabs.js` is found, we trigger the function to render the tab manually.
humitos
force-pushed
the
humitos/update-sphinx-tabs
branch
from
878ca2e
to
9357a7f
Compare
This comment has been minimized.
This comment has been minimized.
|
(Sorry, this comment was supposed to go to #118) |
…itos/update-sphinx-tabs
ericholscher
approved these changes
May 5, 2021
hoverxref/_static/js/hoverxref.js_t
Outdated
| // Once the script has been executed, we remove it from the DOM | ||
| script.parentNode.removeChild(script); | ||
| } | ||
| var src = $('script[src$="_static/tabs.js"]'); |
There was a problem hiding this comment.
Should probably use a different variable for this?
There was a problem hiding this comment.
I renamed them to older_tab_src and newer_tab_src.
I'd like to have a small test suite for JS code too. I'll ask @agjohnson or @davidfischer probably to point myself in the right direction for a nice pattern and/or to some resources to learn from. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use two different selectors for sphinx-tabs<2 and >=2:
sphinx_tabs/tabs.js_static/tabs.jsIf the first one is used, the old code that adds a
scripttag is used. If the second one (sphinx-tabs>=2) is found, we call a small chunk of code to enable the tabs.Closes #104