-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cool project! Some questions/comments #3
Comments
Hi, I'm glad the project was helpful to you.
and others relaited to
Feel free to create any issues, pull requests |
Awesome work porting this! I currently have a C++ application using Box2d and was contemplating the merit of switching to native rust. After a quick search I came across your library and was thrilled to see a native port that is in working condition. I have started porting my code into rust and, so far, I have the following (very minor) notes:
_rs
suffix. From the naming guidelines: "Crate names should not use -rs or -rust as a suffix or prefix. Every crate is Rust! It serves no purpose to remind users of this constantly." Is this because of the other box2d crate that existed already?B2vec
vsB2Vec
. This seems to happen throughout the library with some types assuming the first style and some the latter.glium
(v0.31.0) + imgui/winit (e.g.,WinitPlatform::attach_window
). Is there a reason you aren't using the latestglium
? I ask in case I should be on v0.30.0 as well.Some other questions:
Hopefully I am not being to picky; I am just excited to use this library and would like to help / see it mature. In general, how would you prefer me reporting stuff I find as I dig deeper?
The text was updated successfully, but these errors were encountered: