Replacing future wait with run loop #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Clarkson <d4rkf1br3@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #133 +/- ##
==========================================
+ Coverage 78.36% 78.46% +0.10%
==========================================
Files 71 71
Lines 3046 3042 -4
==========================================
Hits 2387 2387
+ Misses 659 655 -4
Continue to review full report at Codecov.
|
Signed-off-by: Derek Clarkson <d4rkf1br3@gmail.com>
Signed-off-by: Derek Clarkson <d4rkf1br3@gmail.com>
|
This has been replaced with a semaphore in #135 |
|
Cool. That wasn't something I would have thought of as I've never had need to use a semaphore in the past. Always a chance to learn new things :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pursuant to the discussion in #132 I messed about to see if I could come up with something that would allow the future to resolve and the current thread to release.
The NIO API doco actually suggests that using
.wait()might not be a good idea so I decided to try replacing the promise/future with run loop execution. It worked, allowing the.start()function to throw an error if the port was not available both iOS and OSX.However, I'm not an expert in the the NIO code or all the depths of multithreading at that level so whilst this solutions works, it may not be the best one.
All tests were run and green with this code.