Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Inconsistent adjusted order amount with inventory skew #2058

Closed
RC-13 opened this issue Jul 16, 2020 · 3 comments · Fixed by #2224
Closed

[BUG] Inconsistent adjusted order amount with inventory skew #2058

RC-13 opened this issue Jul 16, 2020 · 3 comments · Fixed by #2224
Assignees

Comments

@RC-13
Copy link
Contributor

RC-13 commented Jul 16, 2020

Describe the bug
Every time order refresh, the adjusted order amount in Eterbase exchange changes even if there are no filled trades.

Steps To Reproduce
Here are the steps to reproduce the issue (see attachments in the section below):

  1. Create a pure market making strategy
  2. Set exchange to Eterbase
  3. Disable ping-pong
  4. Disable order_refresh_tolerance_pct
  5. Enable inventory skew, you can use the default skew value or set different inventory_target_base_pct.
  6. Start strategy and wait for orders to refresh.
  7. Check adjusted order amount value on the status window and logs and you will notice that it changes every time order gets refreshed.

Screenshots
eterbase

Release version
0.29.0 and 0.30.0

Attachments
logs_Eterbase.log

WARNING: Do NOT publish any exchange API keys or your wallet's private key. Whoever has access to them may steal your assets!

Optional: your discord username:

@RC-13 RC-13 added the bug label Jul 16, 2020
@dennisocana
Copy link
Contributor

This is caused by the broken balance update as mentioned here in https://github.com/CoinAlpha/hummingbot/issues/2012. Inventory skew uses the available balance instead of the total balance https://github.com/CoinAlpha/hummingbot/issues/1927. Changing issue title since this is not isolated to Eterbase connector. See screenshot below from Liquid.

image

@dennisocana dennisocana changed the title [BUG]Eterbase inconsistent adjusted order amount [BUG] Inconsistent adjusted order amount with inventory skew Jul 16, 2020
@dennisocana dennisocana linked a pull request Jul 16, 2020 that will close this issue
2 tasks
@gabririgo
Copy link
Contributor

+1 on bamboorelay

@dennisocana dennisocana linked a pull request Aug 6, 2020 that will close this issue
2 tasks
@gyozajiro
Copy link
Contributor

#2224

@dennisocana dennisocana linked a pull request Aug 20, 2020 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants