New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Filled order fees are not recorded correctly #2084
Comments
Updating list of connector with active fee issue: |
|
OkEx does not provide trades (order fills) events through the websocket. The only alternative for this connector is to estimate fees (see https://www.okex.com/docs/en/#spot_ws-channel) |
Cooper from Beaxy exchange confirmed that they don't have the possibility for the time being to include fees information in the order update events. |
Blocktane does not provide fee information in the trade websocket channel. They don't include fee information in the websocket order update channel either. They do have a trades REST api that could be used to retrieve fees, but that would require modifying the current client logic to make this call every time a trade is completed, cancelled or failed. |
Coinzoom does not provide fees information in their order update websocket channel. We have to keep estimating fees for the exchange. |
Digifinex does not provide fees information in the trades updates websocket endpoint (https://github.com/DigiFinex/api/blob/master/Websocket_API_en.md). It does not provide that information through the REST API interface, making it impossible to stop estimating fees for this exchange. |
Describe the bug
Fees for orders that are filled are not recorded correctly for many connectors, instead of taking fees reported from exchange's API, the connectors call
c_get_fee
(which estimates fee). This results in incorrect fees stored on trades table (sqlite) and incorrect performance reported onhistory
command.This mistake was partly due to Binance connector had this bug which other connectors copied the code from. The bug was fixed on 29 December 2020 on Binance connector so connectors created after the date should not get affected.
Connectors which broadcast fee incorrectly on
OrderFilledEvent
:KucoinOkExBeaxyBlocktaneCoinzoomDigiFinex┆Issue is synchronized with this Clickup task by Unito
The text was updated successfully, but these errors were encountered: