Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Config variable set to None after CTRL+X #5117

Merged
merged 3 commits into from Feb 25, 2022

Conversation

mhrvth
Copy link
Contributor

@mhrvth mhrvth commented Feb 15, 2022

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

  • Fixes a bug where config variable is set to None when an invalid value is provided and CTRL+X is entered afterwards

Tests performed by the developer:

  • Tried to reproduce the error with target_asset_amount in TWAP
  • Ran unit tests

Tips for QA testing:

  • Try to reproduce the problem with different kinds of variables. The result should always be the previously set value, not None.

@dennisocana
Copy link
Contributor

Copy link
Contributor

@rapcmia rapcmia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test performed:

  • Setup all hummingbot strategies available
  • Select random parameter, example order_amount
  • Enter invalid input and then ctrl+x to cancel, previous value still available
  • Tested on source and docker build

@JeremyKono JeremyKono merged commit ed65661 into hummingbot:development Feb 25, 2022
@mhrvth mhrvth deleted the fix/config_ctrl_x_none branch May 16, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants