-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crypto.com - Hummingbot API is outdated #6023
Comments
Duplicated with this issue: |
Severity: P2 |
We'd like to take up this development bounty - Crypro.com connector. Me and @manibandi. I have previously contributed BitMart to Hummingbot, and have a lot of experience developing connectors and strategies in private. |
Okay, I will assign you both for the bounty of Crypto.com API , but it will be paid at the one address that you provide. |
This issue is assigned to @srirambandi and @mbadran . Thank you for your contribution! |
Yes, of course. So, can we start with the development now. Give us the green signal and we'll start. |
Yep, could start now ✅ |
hi @srirambandi Could you please add any your updates on this bounty? |
@nikspz sorry for the delay. Yes will push our current commits to a draft PR by this Sunday. Still in progress, but from start of next week, our progress will be good. 🙌 |
Hi @srirambandi good day to you, |
Hi @rapcmia and @nikspz, sorry in the delay to update soon. We have created a draft PR, where we are pushing the working commits. We'll be done with the connector logic and test it within a week(using Crypto.com sandbox as we don't have keys for main account). And then we'll write the unit tests for it. So glad the team has planned for including this in the next release! We'll try to get this merged before time. |
I'm deeply saddened to hear that the Crypto.com connector may be removed from Hummingbot due to no HBOT votes this quarter. There are people who use it, I have been using it since 2020 when it was first introduced. There are two gentlemen who took up the bounty offer and are almost finished fixing the code to implement the required connector changes, it would be such a shame to simply stop work and dump the connector from the code. HB team, if you're reading this - please reconsider. I don't hold any HBOT tokens, if I'd known it would have only taken 100k to keep the connector working, I would have personally considered buying the token just to vote. |
I am willing to vote for maintaining crypto dot com's connector, I have been using it for a while and would love to see it maintained |
We are closing this bounty since during Epoch 5 CEX Connectors Poll Crypto.com connector not voted with minimum amount for a CEX connector Also this bounty not ready after more than 2 month period of development, and developer not fix simple issues shortly / not being responsive. |
@Alkhalifah-blockchain @bonez56 If you want crypto.com connector will be added again in the codebase, you will need to create a new Proposal using snapshot. If you need any additional info, please feel free to ask here / in discord proposals forum |
If this goes for another proposal to be voted in, I can finish unit tests and submit the PR again.
@nikspz what small fixes ami missing, let me know. The connector is ready to be tested on the logic. I even pushed some unit tests, although unit tests are not important for bronze connectors all that much as I've read yesterday in our discord comment. I am genuinely asking what small fixes were we missing? |
Hi team,
Crypto dot com exchange has upgraded their API to a the third version a few months ago, and the current connector on Hummingbot is still out of date.
I would like to nominate upgrading the crypto dot com API to avoid delays and ensure optimal execution.
You can find more details about the new API below:
https://static2.crypto.com/exchange/assets/documents/oex-migration-faq.pdf
The text was updated successfully, but these errors were encountered: