Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto.com - Hummingbot API is outdated #6023

Closed
Alkhalifah-blockchain opened this issue Jan 23, 2023 · 16 comments
Closed

Crypto.com - Hummingbot API is outdated #6023

Alkhalifah-blockchain opened this issue Jan 23, 2023 · 16 comments

Comments

@Alkhalifah-blockchain
Copy link
Contributor

Hi team,

Crypto dot com exchange has upgraded their API to a the third version a few months ago, and the current connector on Hummingbot is still out of date.

I would like to nominate upgrading the crypto dot com API to avoid delays and ensure optimal execution.

You can find more details about the new API below:
https://static2.crypto.com/exchange/assets/documents/oex-migration-faq.pdf

@nikspz nikspz changed the title Upgrade crypto.com's connector to the new version Crypto.com - current connector Hummingbot API is outdated and need update Apr 5, 2023
@nikspz nikspz added the bug label May 3, 2023
@nikspz nikspz changed the title Crypto.com - current connector Hummingbot API is outdated and need update Crypto.com - Hummingbot API is outdated May 3, 2023
@nikspz
Copy link
Contributor

nikspz commented May 3, 2023

Duplicated with this issue:
#5868

@nikspz
Copy link
Contributor

nikspz commented May 4, 2023

Severity: P2
Bounty: 50,000 (https://hummingbot.org/maintenance/bugs/)
Rationale: Community bounty related to bronze connector (connector needs API update)

@nikspz nikspz added the P2 label May 4, 2023
@srirambandi
Copy link
Contributor

We'd like to take up this development bounty - Crypro.com connector. Me and @manibandi. I have previously contributed BitMart to Hummingbot, and have a lot of experience developing connectors and strategies in private.

@nikspz
Copy link
Contributor

nikspz commented May 5, 2023

Okay, I will assign you both for the bounty of Crypto.com API , but it will be paid at the one address that you provide.

@nikspz
Copy link
Contributor

nikspz commented May 5, 2023

This issue is assigned to @srirambandi and @mbadran . Thank you for your contribution!

@srirambandi
Copy link
Contributor

Yes, of course. So, can we start with the development now. Give us the green signal and we'll start.

@nikspz
Copy link
Contributor

nikspz commented May 5, 2023

Yep, could start now ✅

@nikspz
Copy link
Contributor

nikspz commented May 24, 2023

hi @srirambandi Could you please add any your updates on this bounty?

@srirambandi
Copy link
Contributor

@nikspz sorry for the delay. Yes will push our current commits to a draft PR by this Sunday. Still in progress, but from start of next week, our progress will be good. 🙌

@rapcmia
Copy link
Contributor

rapcmia commented May 31, 2023

Hi @srirambandi good day to you,
Can you let us know of any update for the PR? The team is planning to add this update to the next release. Thank you

@manibandi
Copy link

Hi @rapcmia and @nikspz, sorry in the delay to update soon. We have created a draft PR, where we are pushing the working commits. We'll be done with the connector logic and test it within a week(using Crypto.com sandbox as we don't have keys for main account). And then we'll write the unit tests for it.

So glad the team has planned for including this in the next release! We'll try to get this merged before time.

@rapcmia rapcmia linked a pull request Jun 2, 2023 that will close this issue
2 tasks
@bonez56
Copy link

bonez56 commented Jul 7, 2023

I'm deeply saddened to hear that the Crypto.com connector may be removed from Hummingbot due to no HBOT votes this quarter. There are people who use it, I have been using it since 2020 when it was first introduced. There are two gentlemen who took up the bounty offer and are almost finished fixing the code to implement the required connector changes, it would be such a shame to simply stop work and dump the connector from the code. HB team, if you're reading this - please reconsider. I don't hold any HBOT tokens, if I'd known it would have only taken 100k to keep the connector working, I would have personally considered buying the token just to vote.

@Alkhalifah-blockchain
Copy link
Contributor Author

I am willing to vote for maintaining crypto dot com's connector, I have been using it for a while and would love to see it maintained

@nikspz
Copy link
Contributor

nikspz commented Jul 7, 2023

We are closing this bounty since during Epoch 5 CEX Connectors Poll Crypto.com connector not voted with minimum amount for a CEX connector
https://snapshot.org/#/hbot.eth/proposal/0x231e942b5f23b406d409f2b12319891ab3c92605e367f75e56015061e905d56e
The PR for removal not-maintained connectors will be ready next week

Also this bounty not ready after more than 2 month period of development, and developer not fix simple issues shortly / not being responsive.

@nikspz nikspz closed this as completed Jul 7, 2023
@nikspz
Copy link
Contributor

nikspz commented Jul 7, 2023

@Alkhalifah-blockchain @bonez56 If you want crypto.com connector will be added again in the codebase, you will need to create a new Proposal using snapshot.
Please review proposed governance changes here:
https://snapshot.org/#/hbot.eth/proposal/0x63958a27907ef6efa072fc92566f91bcf5df7491523ffcc64ecb47f270df9bcd

If you need any additional info, please feel free to ask here / in discord proposals forum
https://discord.com/channels/530578568154054663/1037719198983532604

@srirambandi
Copy link
Contributor

We are closing this bounty since during Epoch 5 CEX Connectors Poll Crypto.com connector not voted with minimum amount for a CEX connector https://snapshot.org/#/hbot.eth/proposal/0x231e942b5f23b406d409f2b12319891ab3c92605e367f75e56015061e905d56e The PR for removal not-maintained connectors will be ready next week

If this goes for another proposal to be voted in, I can finish unit tests and submit the PR again.

Also this bounty not ready after more than 2 month period of development, and developer not fix simple issues shortly / not being responsive.

@nikspz what small fixes ami missing, let me know. The connector is ready to be tested on the logic. I even pushed some unit tests, although unit tests are not important for bronze connectors all that much as I've read yesterday in our discord comment. I am genuinely asking what small fixes were we missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Blocked
Development

Successfully merging a pull request may close this issue.

7 participants