Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binance Connector: use symbol as trading_pair in _all_trade_updates_for_order method #6895

Open
astra-a opened this issue Mar 5, 2024 · 0 comments

Comments

@astra-a
Copy link

astra-a commented Mar 5, 2024

Describe the bug

In _all_trade_updates_for_order of binance_exchange.py, the symbol is assigned in trading_pair field of TradeUpdate class. Btw, the symbol(BTCUSDT) and trading_pair(BTC-USDT) are different in binance.

1709630015759

Steps to reproduce

  1. It works well right now
  2. Some errors will occur if using the trading_pair field in TradeUpdate class to implement some logics in the future.

Release version

v1.25.0

Type of installation

Source

Attach required files

No response

@astra-a astra-a added the bug label Mar 5, 2024
@rapcmia rapcmia added the binance label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants