Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you update axios so it is no longer a critical vulnerability #110

Open
rililive opened this issue May 8, 2022 · 5 comments
Open

Comments

@rililive
Copy link

rililive commented May 8, 2022

Axios could probably be a peer dependency instead. Npm audit marks it as a critical dependency. It should be easy to update.

Also it would be better as a peer dependency because the axios export is a singleton. Setting defaults can get out of wack when you have multiple versions of axios

@hungdev
Copy link
Owner

hungdev commented May 9, 2022

@rililive feel free to create a pull request

@rililive
Copy link
Author

rililive commented May 9, 2022

@hungdev Hi, I have created a branch, but I don't have permissions to push to this repo.

Example changes

"dependencies": {
    "qs": "6.9.4"
},
"peerDependencies": {
    "react-native-webview": "^11.18.2",
    "axios": "^0.27.2"
}

@hungdev
Copy link
Owner

hungdev commented May 14, 2022

You can fork it and create a new pull request to my repo.

@rililive rililive changed the title Could you update axios so it is not longer a critical vulnerability Could you update axios so it is no longer a critical vulnerability May 14, 2022
@rililive
Copy link
Author

Ok, PR here #112

@rililive
Copy link
Author

Please merge publish when you have time. Are there other collaborators with write/publish permissions who have more availability?

I have an extensive background in js/ts, so I'd be happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants