Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new AppIcons for iOS and Android #10

Closed
wants to merge 4 commits into from
Closed

Add new AppIcons for iOS and Android #10

wants to merge 4 commits into from

Conversation

LBeul
Copy link

@LBeul LBeul commented Jun 13, 2020

Implement a fitting icon for both the iOS and Android Launcher instead of the generic Flutter Logo. The Icon was built by myself in Figma and consists of some usual geometric shapes, so no copyright issues with that.

ball

@hungps
Copy link
Owner

hungps commented Jun 13, 2020

@LBeul Great, thanks! Could you please make a transparent background version for android? Cause it looks better if someone like to theming their OS (like using an icon pack with a custom icon background, rounded icon, etc).

And also don't include pubspec.lock (because your pull request only add icons, not changing the code) and generated files (such as .flutter-plugins-dependencies, ios/Flutter/flutter_export_environment.sh). I forget to ignore them in .gitignore, will add next time. Sorry!

I'm currently refactoring the code and it would be nice if this icon can be used as the refresh indicator and loading indicator icon. If you could add a transparent background version icon (pokeball-logo.png - 40x40) to the assets/images folder, it will be awesome.

Thanks again!

@hungps hungps self-requested a review June 13, 2020 15:14
- Change transparency for both iOS and Android
- Add transparent png & svg pokeball asset
@LBeul
Copy link
Author

LBeul commented Jun 15, 2020

Hey there.

In commit 26bb53a, I just swapped the Icons for new ones with transparent background and added both a png and svg to the assets as requested by @scitbiz :)

@@ -0,0 +1 @@
include ':app'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please uncommit this file

@hungps
Copy link
Owner

hungps commented Jun 20, 2020

@LBeul Please rebase your code

@LBeul
Copy link
Author

LBeul commented Jul 16, 2020

@scitbiz should work now

@hungps
Copy link
Owner

hungps commented Jul 16, 2020

@LBeul You pull request still have conflicts, please rebase and squash into one commit only

@hungps
Copy link
Owner

hungps commented Nov 1, 2020

I'll close this issue here because there is no action coming up and the master branch has changed. If you still want to add this, please open a new pull request based on the new master branch. Thank you!

@hungps hungps closed this Nov 1, 2020
@LBeul LBeul deleted the AppIcons branch October 1, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants