Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more pokemons #3

Closed
balvinderz opened this issue Nov 9, 2019 · 4 comments
Closed

Add more pokemons #3

balvinderz opened this issue Nov 9, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@balvinderz
Copy link
Contributor

Hello , I would like to add more pokemons to this app. I scraped pokemon website and have collected 808 pokemons details . Can u assign this to me if this app is still actively maintained.

@balvinderz
Copy link
Contributor Author

the pokemon info are in this format.
{ "name": "Meltan", "id": "#808", "imageurl": "https://assets.pokemon.com/assets/cms2/img/pokedex/full/808.png", "xdescription": "It melts particles of iron and other metals found\nin the subsoil, so it can absorb them into its\nbody of molten steel.", "ydescription": "It melts particles of iron and other metals found\nin the subsoil, so it can absorb them into its\nbody of molten steel.", "height": "0' 08\"", "category": "Hex Nut", "weight": "17.6 lbs", "typeofpokemon": ["Steel"], "weaknesses": ["Fire", "Fighting", "Ground"], "evolutions": ["#808", "#809"], "abilities": [] }

@hungps
Copy link
Owner

hungps commented Nov 9, 2019

Hello , I would like to add more pokemons to this app. I scraped pokemon website and have collected 808 pokemons details . Can u assign this to me if this app is still actively maintained.

Yes of course. Pull requests are always welcome!

@hungps hungps added the enhancement New feature or request label Nov 9, 2019
@balvinderz
Copy link
Contributor Author

PR #4

@hungps
Copy link
Owner

hungps commented Nov 10, 2019

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants