Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why not use toml (or some other config file) instead of environment variables? #1

Closed
A1ex-N opened this issue Feb 14, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@A1ex-N
Copy link

A1ex-N commented Feb 14, 2023

Instead of using a .env file, why not just use a toml file? That way it'd be the same process for windows and linux. Do environment variables have an advantage over just a plain toml file?

@hungrybluedev
Copy link
Owner

That's an excellent suggestion!

I like TOML files because V has a good module supporting them. It'll also be cross-platform. I was using .env files because it's easy to source them. We can just have an automatic detection step for nearby files or add a switch to point to one.

If you're up for it, can you contribute to the project?

@hungrybluedev hungrybluedev added enhancement New feature or request good first issue Good for newcomers labels Feb 14, 2023
@A1ex-N
Copy link
Author

A1ex-N commented Feb 14, 2023

That's an excellent suggestion!

I like TOML files because V has a good module supporting them. It'll also be cross-platform. I was using .env files because it's easy to source them. We can just have an automatic detection step for nearby files or add a switch to point to one.

If you're up for it, can you contribute to the project?

Yeah I'd like to contribute to the project. I'll start working on it tomorrow (it's night time for me right now)

@hungrybluedev
Copy link
Owner

Completed via #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants