Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce dependency reliance for layers regarding data information #93

Open
hunkim98 opened this issue Oct 29, 2023 · 0 comments
Open

Reduce dependency reliance for layers regarding data information #93

hunkim98 opened this issue Oct 29, 2023 · 0 comments
Labels
🧹 cleanup Time to refactor

Comments

@hunkim98
Copy link
Owner

Currently each layer is a child of BaseLayer. The problem is that each child layer has its own column count, row count, topRowIndex, leftColumnIndex, which can be tricky to track its dependency on each other in future works. @Lee-Si-Yoon suggested that we either create diagram for this or control all the pertaining logic into one class.

I believe we have to make some modifications to DottngDataLayer to reduce such chaos.

@hunkim98 hunkim98 added the 🧹 cleanup Time to refactor label Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 cleanup Time to refactor
Projects
None yet
Development

No branches or pull requests

1 participant