Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alert-dialog depends on button, so button also needs to be installed with it #14

Closed
Tracked by #4
huntabyte opened this issue May 28, 2023 · 1 comment
Closed
Tracked by #4

alert-dialog depends on button, so button also needs to be installed with it #14

huntabyte opened this issue May 28, 2023 · 1 comment
Labels
status: under review Further discussion is needed to determine this issue's scope and/or implementation

Comments

@huntabyte
Copy link
Owner

huntabyte commented May 28, 2023 •
edited
Loading

The issue with this is that if someone already has the button installed and has customized it, this would override that customization. I think checking first to see if the button exists and if not, installing it, otherwise, just install the alert dialog.
@huntabyte huntabyte mentioned this issue May 28, 2023
Closed
3 tasks
@huntabyte huntabyte changed the title alert-dialog depends on button, so button also needs to be installed with it enhancement: alert-dialog depends on button, so button also needs to be installed with it May 28, 2023
@huntabyte huntabyte changed the title enhancement: alert-dialog depends on button, so button also needs to be installed with it bug: alert-dialog depends on button, so button also needs to be installed with it May 28, 2023
@huntabyte huntabyte changed the title bug: alert-dialog depends on button, so button also needs to be installed with it enhancement: alert-dialog depends on button, so button also needs to be installed with it May 29, 2023
@huntabyte huntabyte changed the title enhancement: alert-dialog depends on button, so button also needs to be installed with it feature: alert-dialog depends on button, so button also needs to be installed with it Jun 3, 2023
@huntabyte huntabyte added the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Jun 3, 2023
@huntabyte huntabyte changed the title feature: alert-dialog depends on button, so button also needs to be installed with it alert-dialog depends on button, so button also needs to be installed with it Jun 3, 2023
@huntabyte huntabyte mentioned this issue Aug 19, 2023
Merged
4 tasks
@huntabyte
Copy link
Owner Author

Closed by #150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: under review Further discussion is needed to determine this issue's scope and/or implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@huntabyte