Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool generates incorrect platform tag in output filename when run on Linux when using wheel version >0.34.2 #4

Closed
hutchisr opened this issue Apr 14, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@hutchisr
Copy link

hutchisr commented Apr 14, 2022

pywhlobf currently (as of 0.2.3) generates an uninstallable wheel on linux due to an error in the platform tag in the output filename:

As an example:

Running pywhlobf test-0.1.0-py3-none-any.whl dist will produce the output dist/test-0.1.0-cp38-cp38-linux-x86_64.whl. Attempting to run pip3.8 install dist/test-0.1.0-cp38-cp38-linux-x86_64.whl will produce the error ERROR: test-0.1.0-cp38-cp38-linux-x86_64.whl is not a supported wheel on this platform. because linux-x86_64 is not a valid platform tag, it should be linux_x86_64 (note the use of an underscore rather than a dash). Manually renaming the file to the correct pattern solves the issue.

This seems to be related to changes in wheel.bdist_wheel.get_platform in versions 0.35.0 and above.

Related: #1

@hutchisr hutchisr changed the title Tool generates incorrect platform tag in output filename when run on Linux Tool generates incorrect platform tag in output filename when run on Linux when using wheel version >0.34.2 Apr 14, 2022
@huntzhan huntzhan added the bug Something isn't working label Apr 15, 2022
@huntzhan huntzhan self-assigned this Apr 15, 2022
@huntzhan
Copy link
Member

investigating

@huntzhan
Copy link
Member

huntzhan commented Jun 9, 2022

@hutchisr pls help verify this issue has been resolved. feel free to re-open if something is still wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants