File overwritten

[sBoff]

When using the logging with the following config, it doesn't produce the expected results as the file gets overwritten multiple times during startup. This is due to the "appendToFile" value being false. Setting the value to "true" obviously resolves the issue however, the file is no longer overwritten on application startup as required.

I assume as each logger is created, it deletes the existing file and creates a new one.

<appender name="FileAppenderXml" type="log4net.Appender.FileAppender"> <file type="log4net.Util.PatternString" value="Log\ClientApp.xml"/> <appendToFile value="false"/> <layout type="log4net.Layout.XmlLayoutSchemaLog4j"> <locationInfo value="true"/> </layout> <param name="Encoding" value="utf-8" /> </appender>

In essence, any logging that is done prior to the last instance of the logger object being created is deleted. The expected behavior is that all the logging is recorded however, on application startup the existing file is delete (once, if present).

[huorswords]

Hello @sBoff ,

Thank you very much by your feedback.

This seems an issue coming from log4net library itself, as the appender implementation is not a part of Microsoft.Extensions.Logging.Log4Net.AspNetCore nuget.

I'm sorry, my fault, but I don't know how to help you on that.

Can you raise the issue on the corresponding project instead?

Regards.

[sBoff]

Hi @huorswords,

The log4net implementation is fine. It works as expected in other applications. It is the implementation of Log4NetLogger that is causing the problem - specifically this line in the Log4NetLogger constructor:

log4net.Config.XmlConfigurator.Configure(loggerRepository, xmlElement);

I don't believe XmlConfigurator.Configure should not be called for each logger instance that is created. In a typical application, this method is called once at startup. When new loggers are created, this method is not called again. It is this method that causes the log file to be deleted/recreated and hence, wipes out any log entries created before the last instance of Log4NetLogger is created.

I'll put forth a pull request soon.

[huorswords]

Hi again,

Cool, thank you very much! I will wait for the pull request then.

Regards

[sBoff]

@huorswords, I've been trying to do a pull request for the last hour with little success. I can connect to github and authenticate but it always returns the following when I try to push.

ERROR: Permission to huorswords/Microsoft.Extensions.Logging.Log4Net.AspNetCore.git denied to sBoff.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Are there some permissions you need to grant me, or something obvious you know I would be doing wrong?

Regards.

[sBoff]

I ended up having to fork this repository, create the fix, and then do a pull request from my fork to this repo. Is that the normal way? I would have expected to be able to create a branch and do a pull request directly from this repo?

[huorswords]

Hello @sBoff ,

Yes, I think that Fork flow is the default flow on Github repos by default. I didn't change permissions from the beginning, and also I do not include yet the Contributing document on the repo.

My fault, sorry.

Thank you very much by your contribution.

[sBoff]

Thanks @huorswords, I didn't realize forking was the default flow, all sorted now 👍

[huorswords]

Merged!

Thank you very much. I will schedule the master release as soon as possible.

Thank you very much again, @sBoff .

[huorswords]

Hi @sBoff ,

Just to let you know. Your changes are available on the 2.0.3 version of the nuget package.

Thank you. Regards,

[sBoff]

@huorswords, amazing, thanks very much :)