Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Overwriting the native log4net xml configuration using the Net Core configuration system" is case sensitive. #42

Closed
chanjunweimy opened this issue Jul 11, 2018 · 1 comment

Comments

@chanjunweimy
Copy link

What is the problem?

  • Expected "overrided.log" (Overided in appsettings.json) to be generated but "log.txt" (specified in log4net.config) is the one that is generated.

How to reproduce?

What is the reason?

  • I figured out the issue is because when setting attribute value, the attribute key is case sensitive.

If case sensitive is the design, then

  • I would suggest updating README.md to:
    json "Log4net": [ { "XPath": "/log4net/appender[@name='RollingFile']/file", "Attributes": { "value": "overrided.log" } }, { "XPath": "/log4net/appender[@name='RollingFile']/maximumFileSize", "Attributes": { "value": "1024KB" } } ]
@huorswords
Copy link
Owner

Hello @chanjunweimy ,

Thank you again by opening this issue.

I have created a fix, that will be available on next release of the nuget package, that avoids the case sensitive problem that you point out on this issue.

You could find the fix, until the code is merged, on the develop branch. Feel free to test it at tell me if it solves your specific problem.

Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants