-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to override build target #45
Comments
@shuding This was intended to make sure all the output are compatible with es5, mostly for browser compatibility. Override it inside the bundler to let user configure less. |
I think ES5 can be a good default, but shouldn't override user's intention in tsconfig. For example I want to try ESNext to drop IE support. |
TIL from styfle that we can use node version to specific ecmascript version with babel
I'll think of that later, maybe to provide a CLI option instead consuming from tsconfig to make the behavior consistent between js and ts inputs |
Wow that’s interesting… but eventually I believe Bunchee needs its own config file. 😄 |
Since IE is deprecated in 2022 soon, we might want to support es6 output |
IE is now officially out of support, so it's time to change the target version. |
I'm waiting for a change on swc side so that I could adopt swc, then the target will easier to control |
It seems that ES5 is always the build output target, and will override the project tsconfig value:
bunchee/src/rollup-config.ts
Line 85 in 1a4ade8
The text was updated successfully, but these errors were encountered: