Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numbers in HTML attributes are wrongly identified #68

Closed
shuding opened this issue Sep 6, 2023 · 0 comments · Fixed by #72
Closed

Numbers in HTML attributes are wrongly identified #68

shuding opened this issue Sep 6, 2023 · 0 comments · Fixed by #72
Labels
bug Something isn't working

Comments

@shuding
Copy link

shuding commented Sep 6, 2023

For example, the 24 should be a string type instead of an identifier:

<svg fill="none" height="24"/>
@huozhi huozhi added the bug Something isn't working label Sep 6, 2023
@huozhi huozhi mentioned this issue Sep 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: string in jsx attribute huozhi/sugar-high
2 participants
@shuding @huozhi