Prevent branch switching with GitFileReader #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GitFileReader uses a temporary directory to clone to and read from, this clone is always singular to reduce too much temp directories. But when using the GitFileReader it's possible this might cause some side-effects when one file reads from branch A but that file uses the GitFileReader to read from branch B, which would cause a switch (without switching back) and file A not being able to load any other files from branch A (as was expected). Hopefully this will also fix a rather hard to find bug where configuration loading fails randomly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitFileReader uses a temporary directory to clone to and read from, this clone is always singular to reduce too much temp directories.
But when using the GitFileReader it's possible this might cause some side-effects when one file reads from branch A but that file uses the GitFileReader to read from branch B, which would cause a switch (without switching back) and file A not being able to load any other files from branch A (as was expected).
Hopefully this will also fix a rather hard to find bug where configuration loading fails randomly.