Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do we really stipulate a max pageSize? #59

Open
edeutsch opened this issue Feb 14, 2020 · 1 comment
Open

do we really stipulate a max pageSize? #59

edeutsch opened this issue Feb 14, 2020 · 1 comment

Comments

@edeutsch
Copy link
Contributor

Current yaml says:
- name: pageSize
in: query
description: How many items to return at one time (default 100, max 100)
required: false
type: integer
default: 100

I'm fine with a default 100 so that a naive query does not return a billion rows. But why should we stipulate a max of 100? If a client wants to pull all 10,000 PSMs from PXD123, why should they have to do it in chunks of 100? How irritating for them. And extra work for my machine too.

I propose we can keep default of 100, but let each implementing site choose what max or limits to impose. If PRIDE only wants to allow 100 at a time, fine. But I don't think we should prevent PeptideAtlas from returning 10,000 rows if the user asks for it? It's not enforceable anyway via the schema, so I propose we strike that.

Comments?

@ypriverol
Copy link
Contributor

Expanding the error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants