In the PSM object the score should be plural

[ypriverol]

The searchEngineScore in psm should be plural because it is a list

searchEngineScore -> searchEngineScores

[edeutsch]

I agree it should be plural.

But I'm also wondering if something more general is appropriate. PeptideAtlas does not store actual search engine scores, but rather only probabilities. It seems that in general probabilities or q-values or something like that it more useful than search engine scores anyway (e.g., what does a Mascot score of 35 mean again?) What about renaming this thing to something more like "confidenceScores" or "confidenceMetrics" or something like that? That could hold search engine scores or probabilities or q-values or whatever. What do you think?

[ypriverol]

@edeutsch, Im fine with confidenceScores because is more generic. Check here the psm endpoint from PRIDE http://wwwdev.ebi.ac.uk/pride/proxi/archive/v0.1/psms?resultType=full&peptideSequence=YNPTWHCIVGR

[edeutsch]

Looks fantastic!

[ypriverol]

if you agree, we move to confidentScores, please give me a 👍

[edeutsch]

Should be confidenceScores instead of confidentScores

[ypriverol]

@edeutsch can you take a look to this issue #67

[ypriverol]

@edeutsch PR #69 ready to be approved.