You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Testing how we can use issues for code review. So far I'm not happy with the inline comments (blame). Github's interface for this sucks big time. Comments get lost, there is no way of tracking what conversations are active etc. The official suggestion is to use pull requests, which I think is a total overkill unless you are conducting a full code review.
@daneryl @konzz
Testing how we can use issues for code review. So far I'm not happy with the inline comments (blame). Github's interface for this sucks big time. Comments get lost, there is no way of tracking what conversations are active etc. The official suggestion is to use pull requests, which I think is a total overkill unless you are conducting a full code review.
Code style suggestion, replace switch statements with object literals: https://toddmotto.com/deprecating-the-switch-statement-for-object-literals.
https://github.com/huridocs/UwaziDocs/blob/9fcc2009263a36f4885b0e0bcc7bd70dfef2c973/app/react/Templates/components/FilterSuggestions.js
The text was updated successfully, but these errors were encountered: