Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPVoid missing output #28

Closed
Den1al opened this issue May 5, 2016 · 5 comments
Closed

IPVoid missing output #28

Den1al opened this issue May 5, 2016 · 5 comments
Assignees

Comments

@Den1al
Copy link

Den1al commented May 5, 2016

According to the .yaml file, the IPVoid should return the Blacklist status, but it doesn't.
i.e the ip http://www.ipvoid.com/scan/8.8.8.8/ did not return the black list status.

@mcm
Copy link
Contributor

mcm commented May 5, 2016

@Den1al it only pulls the black list info if the IP is actually listed.

@Den1al
Copy link
Author

Den1al commented May 5, 2016

Regardless of the blacklisting status, even knowing that it is safe is good practice.

@mcm
Copy link
Contributor

mcm commented May 5, 2016

Hmm. Lemme think on that. I agree but I'm not sure how best to visualize that without spitting out a ton of lines for each of their blacklists

@Den1al
Copy link
Author

Den1al commented May 5, 2016

What do you mean by tons of lines? There is just one line to add.

On May 5, 2016, at 9:01 PM, mcm notifications@github.com wrote:

Hmm. Lemme think on that. I agree but I'm not sure how best to visualize that without spitting out a ton of lines for each of their blacklists


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@mcm
Copy link
Contributor

mcm commented May 5, 2016

So currently, if you checked an IP that was listed on any of the lists IPVoid checks, you'd get one line of output for each blacklist they're listed on. The config logic doesn't currently (although maybe this is a feature we'd need for this case) support the "lack" of results - that is, there's no way in a site's configuration to say "If none of these match, say 'Not listed'". Instead, you'd have to list EVERY blacklist, and a status of whether its listed. That list is pretty long.

@mcm mcm added the enhancement label May 6, 2016
@tcwaddell tcwaddell self-assigned this Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants