-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When does filter commute with derivatives? #18
Comments
Is |
Yep, you're correct!
Because of this, the post process files include region areas that include land as well as region areas that only account for water. That way, if you want an energy density, you can renormalize by just the water area and not the land area.
To summarize:
|
A short follow-up on this:
This is only applicable for things like velocity, where it should be going to zero along the coastline, and so extending with zeros into land is valid / reasonable. For other fields, such as density, pressure, and SSH, a zero extension isn't valid. For those, more complicated methods are required. In particular, FlowSieve includes a multi-scale interpolator using radial basis functions via the ALGLIB library. This would be done in pre-processing to create a new density field that extends over land, with the interpolated density then being passed in to coarse-graining. This feature isn't highlighted in the documentation and tutorials yet. It's a fairly computationally expensive routine, and hasn't been the focus of our usage so far. Cleaning up that workflow and formalizing a tutorial for it is on the to-do list, but since its not necessary to filter velocity fields, hasn't been a focus. |
Thanks so much for these detailed explanations @bastorer. They are super clear! I suspect that other users will be interested in these answers too, since commutativity is a big pro of the FlowSieve filter operator. We could leave this issue open for future reference? Alternatively, these points could be included in the documentation in the long run (if you agree this would be useful), whenever someone has time to do it. |
I'll plan to wrap this into the documentation, but in the mean time leaving the issue open for reference sounds good :-) |
What settings do I have to choose in
constants.hpp
to guarantee that the filter commutes with derivatives? I suspectDEFORM_AROUND_LAND = false
(does this mean: don't change the kernel shape close to land?)FILTER_OVER_LAND = true
(or is this option merely about whether the output is masked or not, and does not impact the actual filter algo?)These questions are not part of the JOSS review process, just for my own curiosity.
The text was updated successfully, but these errors were encountered: