Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

怎么不能定制width #1

Closed
hihl opened this issue Jun 6, 2016 · 8 comments
Closed

怎么不能定制width #1

hihl opened this issue Jun 6, 2016 · 8 comments

Comments

@hihl
Copy link

hihl commented Jun 6, 2016

No description provided.

@hustcc
Copy link
Owner

hustcc commented Jun 6, 2016

width可以自己在外面包裹一下来定制,例如:

<div className="chart_wrapper">
    <ReactEcharts
        option={this.getOtion()} 
        height={300} />
</div>

然后设置css:

.chart_wrapper {
     width: 60%;
}

@codering
Copy link

codering commented Jun 7, 2016

个人觉得应该直接对外暴露className, style属性,不用height.

@hustcc
Copy link
Owner

hustcc commented Jun 7, 2016

@codering 是的,开始也这么考虑的,开放style和class,不用height~
准备下个版本这么做。欢迎pr^_^~

@hustcc hustcc closed this as completed in 72b54bb Jun 8, 2016
@hustcc
Copy link
Owner

hustcc commented Jun 8, 2016

@hihl @codering v1.1.1 增加className, style,去掉height属性,使用v1.1.0版本将默认height=300px.

@byenow
Copy link

byenow commented Jul 18, 2016

@hustcc 建议修改一下README

@hustcc
Copy link
Owner

hustcc commented Jul 18, 2016

@byenow 需要修改什么?

@byenow
Copy link

byenow commented Jul 18, 2016

@hustcc
Copy link
Owner

hustcc commented Jul 18, 2016

@byenow 感谢提醒,包括demo代码中也有很多的height属性~~~
已经修改~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants