-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript support #106
Comments
Can you do something to help me by a pr? |
hope, #107 can help |
666 |
@hustcc lol, what's that? |
6 has the same pronunciation with 牛 in Chinese, 牛 is cow, but has meaning of perfect, or very good in somewhere. 666(three 6) means very very very good, and admire you for your develop ability. |
@hustcc wow, very instructive, thank you @rileystroud can you please try this branch and confirm if it works for you? You can install it through npm like:
|
@rileystroud merge into master, so just |
It's not working for me on my first pass. I'll get back to it in a couple hours |
@rileystroud how did you install it? can you check if |
It installed fine. The typescript code wasn't compiling to the correct javascript.
compiled to
but there is no default function defined. With #112,
compiles to the expected
|
I checked out your version (#112), it doesn't even compile with typescript ^2.2.1:
Which version of typescript do you use? |
I'm on typescript 2.2.1 |
Yes, sorry, you was right, I incorrectly imported the module. Finally it works for me. But, honestly, I have doubts. Your variant works fine, but syntax Second moment - let's look on the problem from other side. If we write clear typescript file:
and compile it with such ts config:
Generated
As far as we see,
Both Typescript and Babel (webpack 2 does the same, but output is quite bigger) transpile default ES6 style import to ES5 style by adding
@hustcc It will also solve this issue #105 If we do so, then typings that are currently in the project will become working. So, we should decide:
Probably I misunderstand something, correct me if I'm wrong |
@rileystroud @likerRr I think export default is the reason. So I think method 1.1 is better, also can solve #105. |
Shouldn't the constructor return an instance of itself?
|
I hope |
Are you planning on adding support for typescript?
The text was updated successfully, but these errors were encountered: