Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Georgian locale (ka_GE) #158

Closed
wants to merge 2 commits into from
Closed

Conversation

Lukakva
Copy link
Contributor

@Lukakva Lukakva commented Jun 14, 2018

Added translations for the Georgian language.

Although not very well known, Georgian is a unique language spoken only by the citizens of Republic of Georgia (for thousands of years).

I love your library, and since I had to create a Georgian locale for my use anyway, I thought I might as well create a PR.

Not a lot of libraries have Georgian translations, so your library will stand out even more now!

@coveralls
Copy link

coveralls commented Jun 14, 2018

Pull Request Test Coverage Report for Build 380

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.7%) to 29.476%

Totals Coverage Status
Change from base Build 372: -1.7%
Covered Lines: 85
Relevant Lines: 282

💛 - Coveralls

@hustcc
Copy link
Owner

hustcc commented Jun 14, 2018

Thank you very much.

Please help to fill the testease of the locale.

@Lukakva
Copy link
Contributor Author

Lukakva commented Jun 14, 2018

@hustcc There seems to be no language tests in v4.0.0 branch. Should I commit a test file in the master branch?

@hustcc
Copy link
Owner

hustcc commented Jun 14, 2018

There has one test case of en.

@hustcc
Copy link
Owner

hustcc commented Jun 14, 2018

send pr to master, code is merged into master.

@Lukakva
Copy link
Contributor Author

Lukakva commented Jun 14, 2018

Running npm install didn't install jest-date-mock since it was not included in package.json, so I added it. I hope that's okay.

@hustcc
Copy link
Owner

hustcc commented Jun 14, 2018

Seem you pr to timeago.js on branch v4.0.0, you should change to master.

@Lukakva Lukakva changed the base branch from v4.0.0 to master June 14, 2018 20:58
@Lukakva
Copy link
Contributor Author

Lukakva commented Jun 14, 2018

Will open a new pull request, sorry for the inconvenience.

@Lukakva Lukakva closed this Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants