Correctly calculate Content-Length as a byte size #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HTTP server currently is calculating Content-Length as a naive
character count, but the header is supposed to be the byte size of the
response contents. In the case of "Hello World", the two are equivalent,
but, if the response contained special characters, the Content-Length
would be incorrect:
```swift
print("moose".characters.count) // 5
print("møøse".characters.count) // 5
print("møøse".utf8.count) // 7
```
For semantic reasons, and for people who are copying the source to serve
their own custom responses, we should provide the correct byte length.
Signed-off-by: David Celis <me@davidcel.is>
davidcelis
force-pushed
the
content-length
branch
from
c4fd0c7
to
adb64b4
Compare
|
👍 thank you very much! |
huytd
added a commit
that referenced
this pull request
Dec 4, 2015
Correctly calculate Content-Length as a byte size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTTP server currently is calculating Content-Length as a naive
character count, but the header is supposed to be the byte size of the
response contents. In the case of "Hello World", the two are equivalent,
but, if the response contained special characters, the Content-Length
would be incorrect:
For semantic reasons, and for people who are copying the source to serve
their own custom responses, we should provide the correct byte length.
Signed-off-by: David Celis me@davidcel.is