Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestAzure Failure in Vault 1.9.0 #861

Closed
colin-pm opened this issue Sep 8, 2022 · 1 comment · Fixed by #878
Closed

TestAzure Failure in Vault 1.9.0 #861

colin-pm opened this issue Sep 8, 2022 · 1 comment · Fixed by #878
Assignees
Labels
azure Azure auth method and/or secrets engine help wanted Contributions welcome! tests related to tests (not necessarily CI/CD)
Milestone

Comments

@colin-pm
Copy link
Member

colin-pm commented Sep 8, 2022

Vault 1.9.0 introduced the following errors in test_azure.py. Creating an issue to track the resolution of these failures.

FAILED tests/integration_tests/api/secrets_engines/test_azure.py::TestAzure::test_delete_config_0_create_and_then_delete_config - AssertionError: '' != 0
@colin-pm colin-pm added help wanted Contributions welcome! azure Azure auth method and/or secrets engine labels Sep 8, 2022
@colin-pm colin-pm added this to the 1.0.0 milestone Sep 8, 2022
@colin-pm colin-pm added the tests related to tests (not necessarily CI/CD) label Sep 8, 2022
@colin-pm
Copy link
Member Author

This error is due to the addition of two new parameters returned by reading the Azure configuration in Vault 1.9.0, root_password_ttl and use_microsoft_graph_api, which do not return empty strings.

While working on this, I discovered that root_password_ttl returns an int with value 0 instead of a string like the docs type hint describes.
https://www.vaultproject.io/api-docs/secret/azure#root_password_ttl

I reported this issue upstream in hashicorp/vault#17115, but will push up a modifications to the failed test to handle this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure Azure auth method and/or secrets engine help wanted Contributions welcome! tests related to tests (not necessarily CI/CD)
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant