Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The certificate parameter for create_ca_certificate_role will stop accepting file paths in v3.0.0 #914

Open
colin-pm opened this issue Nov 19, 2022 · 0 comments
Open

The certificate parameter for create_ca_certificate_role will stop accepting file paths in v3.0.0 #914

colin-pm opened this issue Nov 19, 2022 · 0 comments
Assignees
@colin-pm
Labels
announcement Announces some change or future change to be aware of breaking-change deprecation Deprecates something, to be removed or changed in a later release tls-cert-auth Related to TLS Certificates Auth Method
Milestone
3.0.0

Comments

@colin-pm
Copy link
Member

colin-pm commented Nov 19, 2022 •
edited

The support to pass the certificate file path with the certificate parameter for cert.create_ca_certificate_role method should be removed in the 3.0.0 release as indicated. The associated test test_create_ca_certificate_with_filename_deprecated should be removed as well.

Action item to be addressed in the future from PR #886
@colin-pm colin-pm added breaking-change tls-cert-auth Related to TLS Certificates Auth Method labels Nov 19, 2022
@colin-pm colin-pm added this to the 2.0.0 milestone Nov 19, 2022
@colin-pm colin-pm self-assigned this Nov 19, 2022
@colin-pm colin-pm mentioned this issue Nov 19, 2022
Merged
@briantist briantist changed the title Remove deprecated parameter support for create_ca_certificate_role The certificate parameter for create_ca_certificate_role will stop accepting file paths in v2.0.0 Nov 19, 2022
@briantist briantist pinned this issue Nov 19, 2022
@colin-pm colin-pm modified the milestones: 2.0.0, 3.0.0 Nov 19, 2022
@colin-pm colin-pm changed the title The certificate parameter for create_ca_certificate_role will stop accepting file paths in v2.0.0 The certificate parameter for create_ca_certificate_role will stop accepting file paths in v3.0.0 Nov 19, 2022
@briantist briantist added deprecation Deprecates something, to be removed or changed in a later release announcement Announces some change or future change to be aware of labels Mar 4, 2023
@briantist briantist mentioned this issue Mar 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-pm colin-pm

Labels
announcement Announces some change or future change to be aware of breaking-change deprecation Deprecates something, to be removed or changed in a later release tls-cert-auth Related to TLS Certificates Auth Method
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@briantist @colin-pm