Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages.config should be deleted #5

Closed
mbp opened this issue Jun 2, 2017 · 3 comments
Closed

packages.config should be deleted #5

mbp opened this issue Jun 2, 2017 · 3 comments

Comments

@mbp
Copy link
Contributor

mbp commented Jun 2, 2017

After converting project, packages.config still remains even though those references are now migrated to <PackageReference> elements.

The file is also specifically mentioned in the generated csproj:

<None Include="packages.config" xmlns="http://schemas.microsoft.com/developer/msbuild/2003" />

Which it should not.

I recommend this file is deleted. Or at least renamed to .old.

@mbp
Copy link
Contributor Author

mbp commented Jun 2, 2017

The same probably applies for any nuspec file being converted to be inside csproj

@hvanbakel
Copy link
Owner

Agreed, but we still need to figure out if we have parity for both files in the new system.

At first I didn't want to touch any of these files but it is weird to keep them included. I think renaming them too is worthwhile and safe.

@hvanbakel
Copy link
Owner

This is now renamed by merging #26 the packages config is now renamed.
I won't delete any file as I cannot assume version control being present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants