Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MELPA package #33

Closed
gpampara opened this issue Nov 29, 2012 · 23 comments
Closed

MELPA package #33

gpampara opened this issue Nov 29, 2012 · 23 comments

Comments

@gpampara
Copy link
Contributor

Would be cool if we added scala-mode2 to the melpa repo? Would be nice to be able to update (for users) from within Emacs itself.

Don't mind doing it but I thought I'd create an issue just to make it visible

@hvesalai
Copy link
Owner

Please do. I don't know anything about that so just tell me if I need to do anything (better if it can all be as easy as pushing to master).

@gpampara
Copy link
Contributor Author

It'll be exactly that

@gpampara
Copy link
Contributor Author

melpa/melpa#391

@hvesalai
Copy link
Owner

Great. Do I need to do anything or is this it?

@gpampara
Copy link
Contributor Author

Well, there are a few things we need to look at (I wasn't aware of them).

MELPA requires that the package name and the recipe file match. Right now there is already a scala-mode which is take from the scala-dist repo. This would require that the name of the mode be changed to scala-mode2, along with the scala-mode(2).el etc. because of the potential conflict with the original scala-mode. This is also mentioned in the melpa issue above.

Other than that we will need a scala-mode2-pkg.el file but that's really minor.

Thoughts?

@gpampara
Copy link
Contributor Author

Are there any plans of deprecating the old mode in favor of scala-mode2?

@hvesalai
Copy link
Owner

Uh-oh. We can always alias scala-mode to be scala-mode2. I haven't dared to propose deprecating the old scala-mode yet. The main reason is that emacs 24 doesn't yet come bundled with any linux distribution and from what I've seen, installing it to e.g. ubuntu isn't that straightforward. Hence I wouldn't feel comfortable declaring scala-mode2 a full replacement for the old scala-mode yet.

Other than that, scala-mode2 doesn't have the REPL integration. I guess it wouldn't be a big thing to merge it, but at the moment it remains on the TODO-list.

@SethTisue
Copy link
Contributor

I think it would be fine to leave the REPL integration to ENSIME and just have a mode that does a good job at indenting and highlighting. I don't think anyone would block replacement of the old mode over that issue.

(How people feel about Emacs 24, I don't know.)

@gpampara
Copy link
Contributor Author

All fair. The alias could probably work but I wonder if that would be ok within the MELPA distribution scheme - it seems to look for mode-name -> filename correspondences.

@hvesalai
Copy link
Owner

Ok, but what if besides scala-mode.el we also had a scala-mode2.el that contained the alias?

I don't know what users of scala-mode2 would think about completely renaming the mode. It would really just need them to search-n-replace the name in their init files, but it would sure cause some hassle.

@hvesalai
Copy link
Owner

hvesalai commented Dec 4, 2012

So what should we do about this?

@SethTisue
Copy link
Contributor

kill the old mode, live in its house, wear its clothes

@gpampara
Copy link
Contributor Author

gpampara commented Dec 5, 2012

Killing the old mode would be preferable - especially seeing as its not been updated in ages and is it not for scala <= 2.8?

Not sure how to go about this though???

@gpampara
Copy link
Contributor Author

gpampara commented Dec 5, 2012

Ok, because the aliasing will basically be rather flaky and questionable, there are 2 options we are basically left with:

  1. Remove the old scala-mode and let scala-mode2 take its place.
  2. Update all the required files, renaming them to scala-mode-xxx2.el. We will have to notify users of the change and encourage them to rather install (and update) the mode using the built-in package.el (for emacs24) or having the emacs23 users install the package manager manually.

One added benefit is that the MELPA packages build very often, something like every 2 hours.

@gpampara
Copy link
Contributor Author

gpampara commented Dec 6, 2012

I'm gonna create a pull request for this one - might take a few days (a bit busy at the moment)

@hvesalai
Copy link
Owner

hvesalai commented Dec 6, 2012

Ok. Let's go ahead with this and also while you do it, please update the README.md to reflect the new preferred way of installing the mode.

@gpampara
Copy link
Contributor Author

gpampara commented Dec 6, 2012

Will do. I'll have the pull request ready as soon as I can - probably ready towards the end of next week.

@undetected1
Copy link

what if just use Marmalade instead. There is also a mode for that -> http://marmalade-repo.org/packages/marmalade

@hvesalai
Copy link
Owner

That sounds good. Gpampara, what do you think?

@undetected1
Copy link

On Fri, 14 Dec 2012 04:03:20 -0800
Heikki Vesalainen notifications@github.com wrote:

That sounds good. Gpampara, what do you think?

Just create account on Marmalade and try to upload the package.
If problem with naming conventions will persist due to legacy
scala-mode, then there is only two ways to solve it:

  1. ask the maintainer(s) (to be precise -- who's uploaded the pkg) on
    MELPA and/or Marmalade to remove this successive package from the repo
    for a sake of new scala-mode;
  2. rename current mode and upload without any conflicts.

Alexander

@gpampara
Copy link
Contributor Author

Sorry that I've been AFK for a while - had to do some travelling, but I'm back now.

Yes, the marmalade packages could work, however, it would mean that the release process is completely manual. MELPA is built directly off the Github repo (I believe its every 2 hours) so you can effectively release many times a day without the need for more effort other than a git push. That being said, there is no harm in also releasing to the marmalade repo - you'd just need some or other version number / date).

There still is some config to be done to reference the package site, but that is general config that I'm just finalising in the updated README. I'll create a pull request with the needed changes tomorrow morning - but for now I'll get some sleep and do it once I'm nice and fresh.

@hvesalai
Copy link
Owner

Merged the melpa pull request with a minor change.

@hvesalai
Copy link
Owner

We are go!

syohex referenced this issue in syohex/melpa Nov 17, 2013
scala-mode2 is an improved scala-mode for emacs. It is losely based on the
original, but has been completely rewritten for scala 2.9 (and 2.10)

The related issue on the project itself is here:
https://github.com/hvesalai/scala-mode2/issues/33

Signed-off-by: Gary Pamparà <gpampara@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants