-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MELPA package #33
Comments
Please do. I don't know anything about that so just tell me if I need to do anything (better if it can all be as easy as pushing to master). |
It'll be exactly that |
Great. Do I need to do anything or is this it? |
Well, there are a few things we need to look at (I wasn't aware of them). MELPA requires that the package name and the recipe file match. Right now there is already a Other than that we will need a Thoughts? |
Are there any plans of deprecating the old mode in favor of scala-mode2? |
Uh-oh. We can always alias scala-mode to be scala-mode2. I haven't dared to propose deprecating the old scala-mode yet. The main reason is that emacs 24 doesn't yet come bundled with any linux distribution and from what I've seen, installing it to e.g. ubuntu isn't that straightforward. Hence I wouldn't feel comfortable declaring scala-mode2 a full replacement for the old scala-mode yet. Other than that, scala-mode2 doesn't have the REPL integration. I guess it wouldn't be a big thing to merge it, but at the moment it remains on the TODO-list. |
I think it would be fine to leave the REPL integration to ENSIME and just have a mode that does a good job at indenting and highlighting. I don't think anyone would block replacement of the old mode over that issue. (How people feel about Emacs 24, I don't know.) |
All fair. The alias could probably work but I wonder if that would be ok within the MELPA distribution scheme - it seems to look for mode-name -> filename correspondences. |
Ok, but what if besides scala-mode.el we also had a scala-mode2.el that contained the alias? I don't know what users of scala-mode2 would think about completely renaming the mode. It would really just need them to search-n-replace the name in their init files, but it would sure cause some hassle. |
So what should we do about this? |
kill the old mode, live in its house, wear its clothes |
Killing the old mode would be preferable - especially seeing as its not been updated in ages and is it not for scala <= 2.8? Not sure how to go about this though??? |
Ok, because the aliasing will basically be rather flaky and questionable, there are 2 options we are basically left with:
One added benefit is that the MELPA packages build very often, something like every 2 hours. |
I'm gonna create a pull request for this one - might take a few days (a bit busy at the moment) |
Ok. Let's go ahead with this and also while you do it, please update the README.md to reflect the new preferred way of installing the mode. |
Will do. I'll have the pull request ready as soon as I can - probably ready towards the end of next week. |
what if just use Marmalade instead. There is also a mode for that -> http://marmalade-repo.org/packages/marmalade |
That sounds good. Gpampara, what do you think? |
On Fri, 14 Dec 2012 04:03:20 -0800
Just create account on Marmalade and try to upload the package.
Alexander |
Sorry that I've been AFK for a while - had to do some travelling, but I'm back now. Yes, the marmalade packages could work, however, it would mean that the release process is completely manual. MELPA is built directly off the Github repo (I believe its every 2 hours) so you can effectively release many times a day without the need for more effort other than a There still is some config to be done to reference the package site, but that is general config that I'm just finalising in the updated README. I'll create a pull request with the needed changes tomorrow morning - but for now I'll get some sleep and do it once I'm nice and fresh. |
Merged the melpa pull request with a minor change. |
We are go! |
scala-mode2 is an improved scala-mode for emacs. It is losely based on the original, but has been completely rewritten for scala 2.9 (and 2.10) The related issue on the project itself is here: https://github.com/hvesalai/scala-mode2/issues/33 Signed-off-by: Gary Pamparà <gpampara@gmail.com>
Would be cool if we added scala-mode2 to the melpa repo? Would be nice to be able to update (for users) from within Emacs itself.
Don't mind doing it but I thought I'd create an issue just to make it visible
The text was updated successfully, but these errors were encountered: