Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow SQLDatabaseSequentialChain to return some Intermedite steps #1582

Closed
brad-nemetski opened this issue Mar 10, 2023 · 1 comment
Closed

Allow SQLDatabaseSequentialChain to return some Intermedite steps #1582

brad-nemetski opened this issue Mar 10, 2023 · 1 comment

Comments

@brad-nemetski
Copy link
Contributor

It would be nice if we could at least get the final SQL and results from the query like we do for SQLDatabaseChain.

I'll try to put together a pull request.
@brad-nemetski brad-nemetski mentioned this issue Mar 10, 2023
Merged
hwchase17 pushed a commit that referenced this issue Mar 11, 2023
@brad-nemetski
Add support for intermediate steps to SQLDatabaseSequentialChain (#1583)
439d000 
for #1582

I simply added the `return_intermediate_steps` and changed the
`output_keys` function.

I added 2 simple tests, 1 for SQLDatabaseSequentialChain without the
intermediate steps and 1 with
@hwchase17 hwchase17 mentioned this issue Mar 11, 2023
Merged
hwchase17 added a commit that referenced this issue Mar 11, 2023
@hwchase17 @brad-nemetski
Add support for intermediate steps to SQLDatabaseSequentialChain (#1583…
cb04ba0 
…) (#1601)

for #1582

I simply added the `return_intermediate_steps` and changed the
`output_keys` function.

I added 2 simple tests, 1 for SQLDatabaseSequentialChain without the
intermediate steps and 1 with

Co-authored-by: brad-nemetski <115185478+brad-nemetski@users.noreply.github.com>
@dosubot
Copy link

dosubot bot commented Aug 17, 2023

Hi, @brad-nemetski! I'm here to help the LangChain team manage their backlog, and I wanted to let you know that we are marking this issue as stale.

Based on my understanding, you suggested adding the ability for SQLDatabaseSequentialChain to return intermediate steps, similar to SQLDatabaseChain. You mentioned that you plan to submit a pull request for this feature. However, there hasn't been any activity on the issue since then.

Before we close this issue, we wanted to check with you if it is still relevant to the latest version of the LangChain repository. If it is, please let the LangChain team know by commenting on the issue. Otherwise, feel free to close the issue yourself, or it will be automatically closed in 7 days.

Thank you for your contribution and understanding!

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Aug 17, 2023
@dosubot dosubot bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 24, 2023
@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brad-nemetski