Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete testing for Vector Stores #2816

Closed
sergerdn opened this issue Apr 13, 2023 · 2 comments
Closed

Complete testing for Vector Stores #2816

sergerdn opened this issue Apr 13, 2023 · 2 comments

Comments

@sergerdn
Copy link
Contributor

sergerdn commented Apr 13, 2023

As part of our efforts to ensure high quality and robustness of Langchain, it's important to acknowledge that we have experienced many issues with the functional capabilities of the Vector Stores, which do not always perform as expected and have been documented as such.

Therefore, we need to implement a comprehensive suite of tests for Vector Stores, covering all the relevant functionality, to ensure that they work as expected, regardless of whether they are local or remote. This will involve testing the ability of the stores to handle text inputs, metadata, IDs, document updates, similarity searches, etc.

Once this testing is complete in full or partial, it should be added to our GitHub flow. This will help us avoid breaking any existing functionality and maintain the quality of our code. With this in place, we can be confident that the Vector Stores will function optimally, and we can avoid any degradation of their functionality in future updates.

In addition, users of Langchain will be able to refer to the tests as a source of information on how to use the Vector Stores effectively. If users have questions about how to perform a specific task with a particular Vector Store, they can look to the tests for answers and guidance. This will improve the overall usability of Langchain and enhance the experience for users.

I am not sure if I will have enough time to implement it, but in any case, I will try to make it possible. At the very least, I will implement a good starting point for it.

#2484
#829
#2491
#2225
and others

hwchase17 pushed a commit that referenced this issue Apr 14, 2023
Improve the integration tests for Pinecone by adding an `.env.example`
file for local testing. Additionally, add some dev dependencies
specifically for integration tests.

This change also helps me understand how Pinecone deals with certain
things, see related issues
#2484
#2816
samching pushed a commit to samching/langchain that referenced this issue May 1, 2023
Improve the integration tests for Pinecone by adding an `.env.example`
file for local testing. Additionally, add some dev dependencies
specifically for integration tests.

This change also helps me understand how Pinecone deals with certain
things, see related issues
langchain-ai#2484
langchain-ai#2816
@dosubot
Copy link

dosubot bot commented Aug 13, 2023

Hi, @sergerdn! I'm helping the LangChain team manage their backlog and I wanted to let you know that we are marking this issue as stale.

Based on my understanding, you opened this issue to discuss implementing tests for Vector Stores in Langchain. You mentioned that you might not have enough time to fully implement it, but you were planning to create a starting point. However, there hasn't been any activity on the issue since then.

Before we close this issue, we wanted to check if it is still relevant to the latest version of the LangChain repository. If it is, please let us know and the LangChain team will take a look. Otherwise, if we don't hear back from you within 7 days, the issue will be automatically closed. Thank you!

Copy link

dosubot bot commented Nov 12, 2023

Hi, @sergerdn! I'm Dosu, and I'm helping the LangChain team manage their backlog. I wanted to let you know that we are marking this issue as stale.

From what I understand, you opened this issue to discuss the need for comprehensive testing of Vector Stores in Langchain. You mentioned that you might not have enough time to fully implement the tests but will try to provide a starting point.

Before we close this issue, we wanted to check if it is still relevant to the latest version of the LangChain repository. If it is, please let us know by commenting on this issue. Otherwise, feel free to close the issue yourself, or it will be automatically closed in 7 days.

Thank you for your contribution!

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Nov 12, 2023
@dosubot dosubot bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 19, 2023
@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant