Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add huggingface tokenizer support for splitting text #45

Closed
hwchase17 opened this issue Nov 1, 2022 · 1 comment · Fixed by #75
Closed

Add huggingface tokenizer support for splitting text #45

hwchase17 opened this issue Nov 1, 2022 · 1 comment · Fixed by #75
Assignees
@hwchase17

Comments

@hwchase17
Copy link
Contributor

Would be good to have some methods that split on tokens as in the OpenAI example

https://github.com/openai/openai-cookbook/blob/459afa7d9bf026c4434f54458dc7d9e7d9f9f5fe/examples/Obtain_dataset.ipynb
@hadsed
Copy link

hadsed commented Nov 4, 2022 •
edited
Loading

So NLTK's sentence and word tokenizers are pretty robust and fast. I'm curious to know how to observe its effectiveness

(Leaving the module link here for easy reference)

@hwchase17 hwchase17 changed the title Add more complex ways of splitting text, rather than just character based. Add huggingface tokenizer support for splitting text Nov 8, 2022
@hwchase17 hwchase17 self-assigned this Nov 8, 2022
@hwchase17 hwchase17 linked a pull request Nov 10, 2022 that will close this issue
huggingface tokenizer #75
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hwchase17 hwchase17

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

huggingface tokenizer langchain-ai/langchain
2 participants
@hadsed @hwchase17